Fixed negativity in sqrt in costs.py by np.clip.#4065
Open
OceanNuclear wants to merge 1 commit intomainfrom
Open
Fixed negativity in sqrt in costs.py by np.clip.#4065OceanNuclear wants to merge 1 commit intomainfrom
OceanNuclear wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Closes #4024 |
OceanNuclear
force-pushed
the
ocean/pc-4024
branch
from
1eb51dd to
4b52644
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4065 +/- ##
=======================================
Coverage 46.60% 46.60%
=======================================
Files 122 122
Lines 28711 28711
=======================================
Hits 13381 13381
Misses 15330 15330 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OceanNuclear
force-pushed
the
ocean/pc-4024
branch
from
4b52644 to
4422c12
Compare
Collaborator
|
@j-a-foster could you please provide a review here as you are Mr Cost Model. Does this change make sense and could it have any negative downstream impacts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patches away the RuntimeWarning caused by sqrt(p_plant_electric_net_mw/1200), where p_plant_electric_net_mw may cross over to negative values briefly during the optimization process (but is expected to always converge on a positive value).
Checklist
I confirm that I have completed the following checks: